Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Setup GH Actions #146

Merged
merged 8 commits into from
Mar 1, 2022
Merged

Setup GH Actions #146

merged 8 commits into from
Mar 1, 2022

Conversation

Cyberbeni
Copy link
Contributor

Based on activity, installing SwiftLint on Linux might not be better than just running it on macOS (it is preinstalled) as it will be cleared from the cache after 2 weeks. (But macOS minutes cost 10x more and macOS runners are more often delayed)

xcpretty is discontinued, so using xcbeautify instead, which is written in swift, so making bigger improvements to it doesn't require sweating blood.

Both SwiftLint and xcbeautify will load from cache if saved in a previous run and caching restrictions allow reloading it. https://docs.github.com/en/free-pro-team@latest/actions/guides/caching-dependencies-to-speed-up-workflows#restrictions-for-accessing-a-cache

@Cyberbeni
Copy link
Contributor Author

Cyberbeni commented Dec 15, 2020

You will probably also need to enable Actions in this repo, they passed in mine: https://github.com/Cyberbeni/LicensePlist/pull/1

@Cyberbeni
Copy link
Contributor Author

Cyberbeni commented Dec 15, 2020

Ah, xcbeautify doesn't expect swift test ... to be used on macOS, I'll probably have time to fix that this weekend: cpisciotta/xcbeautify#48

(If we generate-xcodeproj, the formatting is fine: https://github.com/Cyberbeni/LicensePlist/runs/1558894090?check_suite_focus=true but generate-xcodeproj is getting deprecated)

@Cyberbeni Cyberbeni changed the title Setup GH Actions [WIP] Setup GH Actions Dec 15, 2020
@mono0926 mono0926 marked this pull request as draft December 18, 2020 03:57
@Cyberbeni Cyberbeni changed the title [WIP] Setup GH Actions Setup GH Actions Dec 18, 2020
@Cyberbeni
Copy link
Contributor Author

Cyberbeni commented Dec 18, 2020

@mono0926 The problem was that swift test prints to error output on macOS 🤦
The bunch of warnings could be resolved by updating minimum to Swift 5 (since minimum version to submit to App Store is Xcode 11) and updating dependencies or silenced by using the --quieter --is-ci flags for xcbeautify.

@Cyberbeni Cyberbeni marked this pull request as ready for review December 18, 2020 19:54
@Cyberbeni
Copy link
Contributor Author

resolves #35

@mono0926 mono0926 merged commit 72e4d57 into mono0926:main Mar 1, 2022
@mono0926
Copy link
Owner

mono0926 commented Mar 1, 2022

@Cyberbeni

Thank you for the pull request 👍
I'm sorry it took so long to merge this 🙏
I'm not very good with GitHub Actions, so I kept putting it off 🙏

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants